Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate IdentityKeyStoreResolver #2524

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Integrate IdentityKeyStoreResolver #2524

wants to merge 7 commits into from

Conversation

Binara-Sachin
Copy link

@Binara-Sachin Binara-Sachin commented Jul 22, 2024 •
edited
Loading

Purpose

  • This PR integrates the IdentityKeyStoreResolver class into the OAuth flow.
  • This will allow users to define custom key stores to be used in the authentication flow.

Important

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Binara-Sachin Binara-Sachin marked this pull request as ready for review July 30, 2024 04:39
@Thumimku
Copy link
Contributor

How we plan to handle token-exchange/Org switch when we have different keystores, we have to update those source code also right?

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 55.72%. Comparing base (04da85a) to head (ffd7c83).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...identity/oauth2/authcontext/JWTTokenGenerator.java 0.00% 4 Missing ⚠️
...org/wso2/carbon/identity/oauth2/util/JWTUtils.java 0.00% 4 Missing ⚠️
...g/wso2/carbon/identity/oauth2/util/OAuth2Util.java 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2524      +/-   ##
============================================
- Coverage     56.12%   55.72%   -0.41%     
- Complexity     8092     8227     +135     
============================================
  Files           632      632              
  Lines         46016    47000     +984     
  Branches       7520     7767     +247     
============================================
+ Hits          25827    26191     +364     
- Misses        16472    17000     +528     
- Partials       3717     3809      +92
Flag Coverage Δ
unit 38.12% <58.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DMHP
Copy link
Contributor

DMHP commented Oct 18, 2024

Please link the doc PR which includes the supported flows in oAuth.

@Binara-Sachin Binara-Sachin mentioned this pull request Oct 24, 2024
Open
@Binara-Sachin
Copy link
Author

Please link the doc PR which includes the supported flows in oAuth.

Created the doc PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DInuwan97 DInuwan97 DInuwan97 left review comments

@ImalshaG ImalshaG ImalshaG left review comments

@DMHP DMHP DMHP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Binara-Sachin @CLAassistant @Thumimku @DMHP @DInuwan97 @ImalshaG